Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #1363 (update from spack dev 20241031): set correct mpiifx/mpiifort in MPI meta module, update Intel MPI in site configs #1378

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 12, 2024

Summary

  1. For all site configs that use the Intel classic compilers with Intel's MPI (intel-oneapi-mpi%intel), set variant +classic-names in the external package definition - this makes spack use icc, icpc, ifort. For intel-oneapi-mpi%oneapi (icx, icpx, ifortorifx`), this isn't needed.
  2. Add CI workflow on Ubuntu with icx, icpx, ifx. At some point later, the mixed setup icx, icpx, ifort will go away, but for now, we need both.
  3. Update setup-meta-modules extension: save the compiler config from the preferred compiler (last entry in the list of compilers) so that it is available for creating the MPI meta module. This is needed so that we can set the correct MPI compiler wrapper commands (e.g. mpicc vs. mpiicc vs. mpiicx).

Testing

  • Locally on my laptop with %oneapi (icx, icpx, ifx)
  • CI (checked that all Ubuntu CI runs had the correct MPI compiler wrappers in the MPI meta modules for the given compiler)

Applications affected

None

Systems affected

None really

Dependencies

n/a

Issue(s) addressed

Working towards #912

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

….1, and remove noavx512 variant for openblas
…ormation from preferred compiler to set correct MPI compiler wrapper command in MPI meta module (especially for Intel oneAPI)
@climbfuji climbfuji self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant