Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ami tier2 update 1.9 #1516

Open
wants to merge 15 commits into
base: release/1.9.0
Choose a base branch
from

Conversation

stiggy87
Copy link
Contributor

Summary

Updated configs for tier2 AWS AMI.

Testing

Built and tested both gcc and oneapi using unified-dev.

Pulled jedi-bundle, built, and ran ctest.

Systems affected

AWS

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@@ -202,7 +204,7 @@ exit
```bash
# if in sudo su -
cd /opt
git clone -b develop --recursive https://github.com/jcsda/spack-stack.git
git clone -b release/1.9.0 --recursive https://github.com/jcsda/spack-stack.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This README.md will eventually be merged back into develop. I assume you want this to be reverted when that happens? How do we keep track of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change these now, actually. I was thinking about it, and really the doc update was me making sure I didn't miss a step. I'll change these back to develop since I have instances ready for the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climbfuji I've reverted it back to develop, so we should be good with a merge.

configs/sites/tier2/aws-rocky8/packages_oneapi.yaml Outdated Show resolved Hide resolved
configs/sites/tier2/aws-ubuntu2404/README.md Outdated Show resolved Hide resolved
configs/sites/tier2/aws-ubuntu2404/README.md Outdated Show resolved Hide resolved
@srherbener
Copy link
Collaborator

I'm testing this branch on my EC2 Ubuntu 24.04 instance. The current state of this feature branch enables concretize to work out of the box which is great! I'm currently running spack install. I'll keep you posted.

@srherbener
Copy link
Collaborator

The install failed on numactl. I'm seeing this error in the configure step:

==> numactl: Executing phase: 'autoreconf'
==> [2025-02-13-17:09:55.294813] './autogen.sh'
configure.ac:23: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:23: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
lib/m4sugar/m4sh.m4:594: AS_CASE is expanded from...
lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from...
m4/ax_tls.m4:49: AX_TLS is expanded from...
configure.ac:23: the top level
configure.ac:15: installing 'build-aux/compile'
configure.ac:9: installing 'build-aux/install-sh'
configure.ac:9: installing 'build-aux/missing'
Makefile.am:9: error: Libtool library used but 'LIBTOOL' is undefined
Makefile.am:9:   The usual way to define 'LIBTOOL' is to add 'LT_INIT'
Makefile.am:9:   to 'configure.ac' and run 'aclocal' and 'autoconf' again.
Makefile.am:9:   If 'LT_INIT' is in 'configure.ac', make sure
Makefile.am:9:   its definition is in aclocal's search path.
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
autoreconf: error: automake failed with exit status: 1

I can't get to this again until tomorrow (sorry). In the meantime, do you have any thoughts about what might be causing this? Thanks!

@climbfuji
Copy link
Collaborator

Any feedback on the build error that @srherbener reported?

@stiggy87
Copy link
Contributor Author

I haven't been able to reproduce it. I'll keep trying this morning and hopefully have an update soon!

@srherbener
Copy link
Collaborator

I have sync'd up my local clone on my EC2 instance (about 20 minutes ago) and am trying the build over from scratch. The concretize step worked out of the box, and the install is running now. I'll keep you posted.

@srherbener
Copy link
Collaborator

If @stiggy87 can't reproduce the error, the issue might be that my instance is missing something that @stiggy87 had to install or upgrade (external to spack-stack) to get the spack-stack build working. I launched my instance about a month ago, and we have been trying to keep it up to date (but who knows?). I would be inclined to abandon testing my instance if @stiggy87's works (call the PR good), build the AMI from his instance, and I can destroy my instance and relaunch it from the new AMI.

@stiggy87
Copy link
Contributor Author

Found the issue, the libtool package wasn't installed on my test instances.

@srherbener
Copy link
Collaborator

I'll try adding libtool to my instance, and retry the build. I'm not clear if anyone has done the build from scratch yet, so I've changed my mind and thought it would be good for me to try again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants