Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [email protected] to spack, don't make default yet #711

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 15, 2023

Summary

The purpose of this PR is to update the spack submodule pointer for the changes in JCSDA/spack#302 and to verify that the new version isn't used by default.

Testing

Installed on my macOS. Testing this version will require updates to the ufs-weather-model and JEDI codes.

Applications affected

None for now (since the new version isn't used by default - confirmed by testing locally and inspecting CI output).

Systems affected

n/a

Dependencies

Issue(s) addressed

Working towards #709

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji marked this pull request as ready for review August 15, 2023 19:36
@climbfuji climbfuji self-assigned this Aug 15, 2023
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds on my Mac successfully. I guess it should since nothing is really changing yet.

@climbfuji climbfuji merged commit 6d0b8ea into JCSDA:develop Aug 15, 2023
6 checks passed
@climbfuji climbfuji deleted the feature/add_but_dont_use_fms_2023p02 branch August 15, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants