Add util to check executables/shared libs for missing shared libs #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@climbfuji if this looks useful, can you populate the Darwin block with the appropriate command(s) & output pattern (I think it'll involve |
|
Thanks @AlexanderRichert-NOAA I can do the macOS part, but realistically not before the 1.6.0 release. |
climbfuji
reviewed
Dec 7, 2023
|
@climbfuji if you're okay with merging this as-is, it'd be nice to have this at least in the ubuntu CI before the 1.6.0 release, then we can circle back later and add macOS+CI? |
climbfuji
approved these changes
Dec 8, 2023
| bin_list = glob.glob(os.path.join(searchpath, "*/*/*/bin/*")) | ||
| dlib_list = glob.glob(os.path.join(searchpath, "*/*/*/lib*/*.{so,dylib}")) | ||
|
|
||
| master_list = bin_list + dlib_list |
There was a problem hiding this comment.
DEI! DEI! We'll rename this to something less clear but politically correct when we add the macOS feature :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by the issue we ran into with met having a missing python dependency (rpath wasn't set), this PR adds a utility to check installations for missing shared library dependencies of libraries and executables.
Testing
Tested on Orion and in CI.
Applications affected
none
Systems affected
none
Dependencies
#884 / JCSDA/spack#371 (wait for met/python dep fix)
Issue(s) addressed
none
Checklist