Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in .github/workflows/ubuntu-rnd-x86_64.yaml #955

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jan 17, 2024

Summary

This is take 2 of fixing the R&D CI runs. I introduced two bugs in the last PR that this PR fixes. But I decided to stay away from implementing a more complicates matrix-strategy in Github actions because of the reasons outlined in #950 (comment).

Testing

Applications affected

n/a

Systems affected

JCSDA R&D AWS ParallelCluster used for CI runs

Dependencies

none

Issue(s) addressed

Resolves #950

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jan 17, 2024
@climbfuji climbfuji self-assigned this Jan 17, 2024
@climbfuji climbfuji marked this pull request as ready for review January 17, 2024 14:32
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@climbfuji climbfuji enabled auto-merge (squash) January 17, 2024 16:56
@climbfuji climbfuji merged commit 3b680ec into JCSDA:develop Jan 17, 2024
8 checks passed
@climbfuji climbfuji deleted the bugfix/rnd_ci_take2 branch January 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Suggested improvements for R&D CI runs
2 participants