Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No szip for WCOSS2 hdf5 & netcdf #979

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

No szip for WCOSS2 hdf5 & netcdf.

@climbfuji
Copy link
Collaborator

We don't need szip anywhere - can you instead remove it entirely (common / packages.yaml)?

@AlexanderRichert-NOAA
Copy link
Collaborator Author

@edwardhartnett @junwang-noaa is it correct to say we don't need szip support for hdf5/netcdf anywhere? I think we discussed this some time ago but I don't remember what the conclusion was.

@climbfuji climbfuji changed the title Update spack.yaml No szip for WCOSS2 hdf5 & netcdf Jan 31, 2024
@edwardhartnett
Copy link
Collaborator

Correct.

Both HDF5 and netCDF will build with or without szip (a.k.a. szlib). So unless we have some group that is demanding to use szip, or we have some szip-packed netCDF data we need to work with, we don't have to build it.

Both zlib and especially zstandard are better choices (faster, more compressive), so there's no reason for anyone to use this archaic compression.

@climbfuji
Copy link
Collaborator

Thanks Ed, that was my understanding as well.

@climbfuji
Copy link
Collaborator

Looks good! I'll take a look at the CI tests to check that it indeed built hdf5 and netcdf-c w/o szip support.

@AlexanderRichert-NOAA AlexanderRichert-NOAA merged commit 3d09112 into develop Jan 31, 2024
7 checks passed
@AlexanderRichert-NOAA AlexanderRichert-NOAA deleted the AlexanderRichert-NOAA-patch-1 branch January 31, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants