Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jedi-geos-env to unified-dev and skylab-dev templates, set additional env variable for Derecho #982

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Feb 1, 2024

Summary

  1. Derecho needs an additional environment variable - set in compilers.yaml (see Derecho requires additional environment variable set (sometimes). #957 for more information)
  2. Add previously created jedi-geos-env virtual package to unified-dev and skylab-dev templates

Testing

  • CI

Applications affected

None

Systems affected

Derecho (but see #957 for feedback from the sysadmins that the flag can be set in any case).

Dependencies

n/a

Issue(s) addressed

Resolves #957
Working towards https://github.com/JCSDA-internal/AOP23/issues/33

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Feb 1, 2024
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Feb 1, 2024
@climbfuji climbfuji marked this pull request as ready for review February 1, 2024 13:57
@climbfuji
Copy link
Collaborator Author

Reviewers, this PR is ready for review and merging. Thanks!

Copy link

@byoung-joo byoung-joo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for Derecho configuration!

Copy link
Collaborator

@ulmononian ulmononian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@climbfuji climbfuji merged commit 268a23b into JCSDA:develop Feb 2, 2024
7 checks passed
@climbfuji climbfuji deleted the feature/geos-jedi-env_derecho_env_var branch February 2, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Derecho requires additional environment variable set (sometimes).
3 participants