Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding jasper to jedi-mpas-env #989

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Adding jasper to jedi-mpas-env #989

merged 1 commit into from
Feb 6, 2024

Conversation

ashley314
Copy link
Collaborator

@ashley314 ashley314 commented Feb 6, 2024 •
edited
Loading

Summary

Adding the jasper package to jedi-mpas-env

Testing

Describe the testing done for this PR.

Applications affected

jedi-mpas

Issue(s) addressed

Resolves #914

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@ashley314 ashley314 self-assigned this Feb 6, 2024
@ashley314 ashley314 added the INFRA JEDI Infrastructure label Feb 6, 2024
@ashley314 ashley314 marked this pull request as ready for review February 6, 2024 21:04
srherbener
srherbener approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't test on my Mac, but the CI testing covers Mac, both arm64 and x86_64 architectures. It looks like jasper is being built and successfully loads into an environment (lua modules) in the log files.

@climbfuji climbfuji merged commit 4b0c037 into JCSDA:develop Feb 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srherbener srherbener srherbener approved these changes

@climbfuji climbfuji climbfuji approved these changes

Assignees

@ashley314 ashley314

Labels
INFRA JEDI Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add jasper (already being built) to jedi-mpas-env virtual package
3 participants
@ashley314 @climbfuji @srherbener