Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release/1.4.1 into jcsda_emc_spack_stack #296

Merged
merged 13 commits into from
Jul 14, 2023
Merged

Merge release/1.4.1 into jcsda_emc_spack_stack #296

merged 13 commits into from
Jul 14, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 14, 2023 •
edited
Loading

Description

See title. This is pretty straightforward, but needs to be tested as part of the associated spack-stack PR JCSDA/spack-stack#671.

Note that the CI tests are expected to fail, because they fail currently on develop (but check the style tests, these need to pass).

Issue(s) addressed

See JCSDA/spack-stack#671

Dependencies

n/a

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (as part of the spack-stack PR)
  • I have run the unit tests before creating the PR

AlexanderRichert-NOAA and others added 11 commits June 20, 2023 09:23
@AlexanderRichert-NOAA
add noarch variant to scotch to disable SPACK_TARGET_ARGS
beba48a
@AlexanderRichert-NOAA
Update bufr package.py for v12.0.0
83b5b9b
@AlexanderRichert-NOAA
remove debug line
12152da
@climbfuji
Add [email protected]
dee28c6
@climbfuji
Merge pull request #283 from climbfuji/feature/eckit_1p23p1
61d17b1 
release/1.4.1: Add [email protected]
@AlexanderRichert-NOAA
Merge branch 'release/1.4.1' into ufs_jun2023
b9f90a2
@AlexanderRichert-NOAA
Merge pull request #282 from AlexanderRichert-NOAA/ufs_jun2023
a2dc00c 
Add noarch variant to scotch to disable SPACK_TARGET_ARGS
@AlexanderRichert-NOAA
Add MPI (MPI_Fint/mpi_comm_f2c) patch to scotch/parmetis
f792dbd
@AlexanderRichert-NOAA
add comment for parmetis mpi patch
1dec96d
@AlexanderRichert-NOAA
Merge pull request #291 from AlexanderRichert-NOAA/scotch_mpi_patch
a041f7d 
Add MPI (MPI_Fint/mpi_comm_f2c) patch to scotch/parmetis
@climbfuji
Merge branch 'release/1.4.1' of https://github.com/jcsda/spack into f…
5f91a38 
…eature/merge_141_into_jcsda_emc_spack_stack
@climbfuji climbfuji mentioned this pull request Jul 14, 2023
Closed
26 tasks
@climbfuji climbfuji self-assigned this Jul 14, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jul 14, 2023
@climbfuji climbfuji mentioned this pull request Jul 14, 2023
Merged
4 tasks
@climbfuji climbfuji marked this pull request as ready for review July 14, 2023 13:19
srherbener
srherbener approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but I'm not knowledgable on the SCOTCH packaging. It would be good to have additional reviews/testing for the SCOTCH package.

@climbfuji climbfuji merged commit 01d6aa5 into jcsda_emc_spack_stack Jul 14, 2023
@climbfuji climbfuji deleted the feature/merge_141_into_jcsda_emc_spack_stack branch July 14, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulmononian ulmononian ulmononian approved these changes

@srherbener srherbener srherbener approved these changes

@natalie-perlin natalie-perlin Awaiting requested review from natalie-perlin

@AlexanderRichert-NOAA AlexanderRichert-NOAA Awaiting requested review from AlexanderRichert-NOAA

Assignees

@climbfuji climbfuji

Labels
INFRA JEDI Infrastructure
Projects
No open projects
spack-stack-1.5.0 (2023 Q3)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@climbfuji @srherbener @ulmononian @AlexanderRichert-NOAA