Root: Suppress error message for saving empty bbsmenu.txt #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBSMENUのデータが無い場合は空データをbbsmenu.txtに保存しますが 意図しないエラーメッセージが表示されるため修正して抑制します。 修正前も抑制のロジックを導入していましたが別のローカル変数と 取り違えていました。
ローカル変数の名前が冗長で紛らわしいため短く変更します。 また、if文の初期化(if statement with initializer)を利用して 変数のスコープを限定します。
ma8ma
deleted the
root-suppress-error-message-for-saving-empty-bbsmenu-txt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root: Suppress error message for saving empty bbsmenu.txt
BBSMENUのデータが無い場合は空データをbbsmenu.txtに保存しますが意図しないエラーメッセージが表示されるため修正して抑制します。
修正前も抑制のロジックを導入していましたが別のローカル変数と取り違えていました。
Rename local variables for
Root::save_bbsmenu()ローカル変数の名前が冗長で紛らわしいため短く変更します。
また、if文の初期化(if statement with initializer)を利用して変数のスコープを限定します。
関連のpull request: #1307