Linux: rounded borders for popups #964
Open
+429
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A snapshot for this PR is now available. Prebuilt binaries (Artifacts) are available here (requires GitHub login): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables rounded borders on Linux (including drop shadow) for popups. (issue #949; see also PRs #643 and #772)
PopupMenu (Ubuntu 24.10):
macOS theme (running on Ubuntu 24.10) using larger corner radius for popup menus:
ComboBox:
ToolTip:
The rounded popup borders are enabled by default for all themes and
use the same UI properties and client property as in PRs #643 and #772.
Known issues
When popup becomes visible, the background is black for some milliseconds, which does not look very nice when moving mouse over menubar:
2025-01-27_17-31-55.mp4
Components may paint over the rounded border corners. E.g. the red selection of a combobox popup:
If moving mouse down, rounded border in corners is still missing:
Artifacts in corners on KDE when using display scale:
Feedback wanted
Currently, I've tested this only on Ubuntu 24.10 and on KDE neon 6.2.
Would be great to get some feedback whether this works without problems on other Linux distros/versions.