Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional "(City)" in Viewport labels #579

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

YellowOnion
Copy link
Contributor

Motivation / Problem

I was watching Master Hellish's S10 Let's play

And noticed that City Builder Script had a ".::City::." label on the cities, and thought this would be a handy feature on every game, especially when trying to find Cities quickly (say when comparing two towns with the same resources, and wanting to know what one to invest in at a glance).

Description

Provides a "City in Label" option similar to "Population in Label" option.

I'm woobilicious on the discord.

Limitations

Needs translations.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@JGRennison
Copy link
Owner

I've got no objections to this change in principle, but I'm not really keen on duplicating all the strings for each new thing that could be added to the town label.
This creates unnecessary work for the translators.
I'm going to look into the string handling and see if this can be handled without a large increase in the number of strings.

@JGRennison JGRennison merged commit 924b2ab into JGRennison:jgrpp Jul 30, 2023
13 checks passed
@JGRennison
Copy link
Owner

Thanks for this, I've merged it with some adjustments

@JGRennison JGRennison temporarily deployed to github-pages July 30, 2023 21:10 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants