Feature: orderlist Importing / Exporting. #679

lucaFiorini · 2024-03-28T20:59:14Z

No description provided.

lucaFiorini · 2024-03-28T20:59:32Z

the system is now fully operational, imporing and exporting should work.

src/order_cmd.cpp

src/fios_gui.cpp

src/order_cmd.cpp

JGRennison · 2024-03-28T21:33:15Z

src/order_cmd.cpp

+	auto& headJson = json["head"];
+	for (unsigned int i = 0; auto &SD : SD_data) {
+
+		headJson["scheduled-dispatch"][i++] = nlohmann::json::parse(SD.ToJSONString());


Serialising a JSON string and then immediately parsing it suggests that a string is not really the right return type?

I was trying to avoid having to include the json library in the headers, but I guess you are right.
Should it be changed to just use a json object then?

That would likely be better, I agree that including the JSON library everywhere is not ideal, but I can resolve that later on

src/order_gui.cpp

JGRennison · 2024-03-28T21:38:03Z

src/order_cmd.cpp

+		if (extraJson.contains("dispatch-index"))
+			 extraJson["dispatch-index"].get_to(new_order.extra->dispatch_index);
+
+		if (extraJson.contains("xdata"))


These bypass all the order flag and value validation, so likely some changes are needed here. Something for me to look into later probably.

src/order_cmd.cpp

JGRennison · 2024-03-28T21:40:05Z

src/fios_gui.cpp

@@ -367,9 +474,9 @@ struct SaveLoadWindow : public Window {
 		this->querystrings[WID_SL_FILTER] = &this->filter_editbox;
 		this->filter_editbox.cancel_button = QueryString::ACTION_CLEAR;

-		/* pause is only used in single-player, non-editor mode, non-menu mode. It
+		/* pause is only used in single-player, non-editor mode, non-menu mode, when not operationg on orderlists. It


There are quite a lot of spelling errors like this

JGRennison · 2024-03-28T21:42:56Z

src/schdispatch_cmd.cpp

-		ds.UpdateScheduledDispatch(nullptr);
-		SetTimetableWindowsDirty(v, STWDF_SCHEDULED_DISPATCH);
+		if (scheduleJson == nullptr) {
+			if (p2 == 0) return CMD_ERROR;


This check shouldn't be within DC_EXEC because text and exec runs should return the same command result (except where flagged otherwise).

So what solution do you suggest? Should I move it outside of DC_EXEC by checking that condition twice?
I.E. something like
if(scheduleJson == nullptr && p2 == 0) return CMD_ERROR;

…ntation.

…splay station names in output json