Fix: linuxInode is saved in VS Code settings #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxInode was meant to be temporary variable.
Mateusz-Grzelinski
changed the title
JacquesLucke
requested changes
Sep 30, 2024
src/blender_executable.ts
Outdated
| @@ -180,6 +180,10 @@ async function getFilteredBlenderPath(type: BlenderType): Promise<BlenderPathDat | |||
| // update VScode settings | |||
| if (settingsBlenderPaths.find(data => data.path === pathData.path) === undefined) { | |||
| settingsBlenderPaths.push(pathData); | |||
| // do not save linuxInode is settings | |||
| for (const settingExe of settingsBlenderPaths) { | |||
| settingExe.linuxInode = undefined; | |||
There was a problem hiding this comment.
Maybe it's better to explicitly mention the properties that should be stored instead of excluding some? That makes it more obvious what's going on imo.
| linuxInode?: never; | ||
| } | ||
|
|
||
| export type BlenderExecutablesRuntime = { |
There was a problem hiding this comment.
what about a separate type for saving settings? unfortunately renaming made some noise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not squash merge.
Needs to be tested on linux, now I do not have access to linux.