Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical render added and autoplay option added #266

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

poojan010
Copy link

I have added vertical render functionality so now swipe up and down can also be possible
also added new prop autoPlay which will be used to scroll slides automatically
Indentation is modified with 2 spaces

src/index.tsx Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
@poojan010 poojan010 requested a review from Jacse March 6, 2023 01:54
@poojan010
Copy link
Author

poojan010 commented Mar 7, 2023

i have implemented the changes you requested
@Jacse

src/index.tsx Outdated Show resolved Hide resolved
@Jacse
Copy link
Owner

Jacse commented Mar 8, 2023

Hi @poojan010 there are a few unresolved comments / questions. Could you also add something to the documentation (maybe include a screenshot as well)?

@poojan010
Copy link
Author

Hi @Jacse I have Fixed unresolved comments / questions and even added screenshots to docs I have used background colours for slides because i did not have images that you used to generate screenshots for basic example

@poojan010
Copy link
Author

@Jacse ^^

@Jacse
Copy link
Owner

Jacse commented Mar 15, 2023

Hi again @poojan010 thanks for the persistence. I'm really sorry to tell you this now, but seeing it I don't think vertical rendering is something we should support. I have a hard time thinking that this is often useful (but I could be wrong). The autoplay I will gladly merge, though.

@poojan010
Copy link
Author

Do you think changing skip and next button UI will make vertical render better ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants