Web: fix on scroll end #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacse
requested changes
Mar 15, 2023
| @@ -81,6 +81,7 @@ export default class AppIntroSlider<ItemT = any> extends React.Component< | |||
| height: 0, | |||
| activeIndex: 0, | |||
| }; | |||
| _timeout = 0; | |||
There was a problem hiding this comment.
Suggested change
| _timeout = 0; | |
| _webScrollEndTimeout = null; |
Comment on lines
248
to
+250
| _onMomentumScrollEnd = (e: {nativeEvent: NativeScrollEvent}) => { | ||
| this._onScrollEnd(e); | ||
| }; |
There was a problem hiding this comment.
Looks like this function now serves no purpose, I'd remove it and just set onMomentumScrollEnd={this._onScrollEnd} in the render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On web onMomentumScrollEnd is never triggered, this fixes it by listening to the onScroll event with a timeout to trigger the same logic.