Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace window.contextJsParameters by window.digitalData.page.pageInf… #74

Merged
merged 2 commits into from
Jun 25, 2024
Merged

replace window.contextJsParameters by window.digitalData.page.pageInf… #74

merged 2 commits into from
Jun 25, 2024

Conversation

hduchesne
Copy link
Contributor

…o.language

JIRA

https://jira.jahia.org/browse/PROJECT-XXX

Description

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@Fgerthoffert Fgerthoffert requested a review from a team June 24, 2024 12:23
jsinovassin
jsinovassin previously approved these changes Jun 24, 2024
View reviewed changes
@hduchesne hduchesne requested a review from dgriffon June 24, 2024 15:01
@hduchesne hduchesne merged commit b1b73dc into master Jun 25, 2024
5 checks passed
@hduchesne hduchesne deleted the QA-15202 branch June 25, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgriffon dgriffon dgriffon approved these changes

@jsinovassin jsinovassin jsinovassin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hduchesne @dgriffon @jsinovassin