Fixes on dropdown/menu (#54)

Jahia · Oct 4, 2023 · 58203a6 · 58203a6
1 parent c9ab177
commit 58203a6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@jahia/cypress",
-  "version": "3.17.1",
+  "version": "3.17.2",
   "scripts": {
     "build": "tsc",
     "lint": "eslint src -c .eslintrc.json --ext .ts"

diff --git a/src/page-object/moonstone/dropdown.ts b/src/page-object/moonstone/dropdown.ts
@@ -7,7 +7,9 @@ export class Dropdown extends BaseComponent {
 
     select(item: string): Dropdown {
         this.get().click();
-        getComponent(Menu, null, $el => expect($el).to.be.visible).select(item);
+        // eslint-disable-next-line cypress/no-unnecessary-waiting
+        cy.wait(500);
+        getComponent(Menu, this).select(item);
         return this;
     }
 }

diff --git a/src/page-object/moonstone/menu.ts b/src/page-object/moonstone/menu.ts
@@ -1,7 +1,7 @@
 import {BaseComponent} from '../baseComponent';
 
 export class Menu extends BaseComponent {
-    static defaultSelector = '.moonstone-menu:visible'
+    static defaultSelector = '.moonstone-menu:not(.moonstone-hidden)'
 
     select(item: string): Menu {
         // eslint-disable-next-line cypress/no-unnecessary-waiting