Jai/TLI 101.e -- Added ability to upload multiple model and fixed graphs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cash-app-bias-busters ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
armaganngul
reviewed
Nov 22, 2024
armaganngul
reviewed
Nov 22, 2024
| }, | ||
| y: { | ||
| min: 0, | ||
| max: 1, | ||
| beginAtZero: true, // Ensure y-axis starts at zero | ||
| title: { | ||
| display: true, // Show the title |
There was a problem hiding this comment.
looks good! can we do this for chart component1 as well?
armaganngul
reviewed
Nov 22, 2024
| "#99CC99", // Darker bright green 4 | ||
| "#99FF99", // Bright green 5 (unchanged) | ||
| "#FF5733", // Vibrant Red | ||
| "#33FF57", // Vibrant Green |
There was a problem hiding this comment.
these colors need to change (I assume the CSS will handle that?
There was a problem hiding this comment.
Yea, this is just placeholder, we need to revamp the entire theme and layout of this page
armaganngul
reviewed
Nov 22, 2024
| @@ -188,7 +186,7 @@ const Dashboard2 = () => { | |||
|
|
|||
| <div className="chart-section"> | |||
| {Object.keys(graphData).length > 0 && ( | |||
| <ChartComponent2 chartData={graphData} /> | |||
| <ChartComponent2 chartData={graphData} generationalResults={generationResults} /> | |||
There was a problem hiding this comment.
can you explain what generationalResults const do?
There was a problem hiding this comment.
Its a variable for storing the tooltip hover data for each bar of the graph
|
Looks good Jai thanks! Go through my comments but other than that works fine |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Feature Implementation:
This PR enables the functionality for uploading multiple models to Dashboard 2. The system has been updated to handle file validation, properly store uploaded models, and display corresponding data and graphs for each model. The following changes have been made:
Multiple Model Upload: Users can now upload multiple models at once instead of uploading one at a time.
File Validation: The system checks the file types of uploaded models and ensures only valid model files are accepted. Invalid files trigger an error message.
Error Handling: Several error scenarios have been accounted for:
Dashboard 2 Output: The dashboard now correctly generates data and graphs for each uploaded model. Each model's respective data is shown, and graphs are plotted accordingly.
Local Storage: Uploaded models are stored in local storage and are retrievable without any issues, ensuring persistence between sessions.
Graph Enhancements:
Acceptance Criteria:
Testing: