Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support diffing uses-permission counts #274

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Apr 30, 2024

There might be significant differences in blame attribution for AndroidManifest.xml. We usually pay close attention to changes in versionCode, targetSdk, and the count of uses-permissions. Adding an extra line to display the result.

OLD: before.apk (signature: V1, V2, V3)
NEW: after.apk (signature: V1, V2, V3)

          │          compressed           │          uncompressed
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │   1.7 MiB │   1.7 MiB │   0 B │   3.8 MiB │   3.8 MiB │    0 B
     arsc │ 372.3 KiB │ 372.3 KiB │   0 B │ 372.2 KiB │ 372.2 KiB │    0 B
 manifest │   2.8 KiB │   2.8 KiB │ -30 B │  11.2 KiB │    11 KiB │ -176 B
      res │ 266.9 KiB │ 266.9 KiB │  -4 B │ 380.9 KiB │ 380.9 KiB │    0 B
    asset │   6.1 KiB │   6.1 KiB │   0 B │   5.9 KiB │   5.9 KiB │    0 B
    other │  28.9 KiB │  28.9 KiB │   0 B │  58.9 KiB │  58.9 KiB │    0 B
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │   2.4 MiB │   2.4 MiB │ -34 B │   4.6 MiB │   4.6 MiB │ -176 B

 DEX     │ old   │ new   │ diff
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0
 strings │ 25213 │ 25213 │ 0 (+0 -0)
   types │  5662 │  5662 │ 0 (+0 -0)
 classes │  4444 │  4444 │ 0 (+0 -0)
 methods │ 25556 │ 25556 │ 0 (+0 -0)
  fields │ 28471 │ 28471 │ 0 (+0 -0)

 ARSC    │ old  │ new  │ diff
─────────┼──────┼──────┼──────
 configs │   49 │   49 │  0
 entries │ 2416 │ 2416 │  0

=================
====   APK   ====
=================

    compressed    │   uncompressed    │
──────────┬───────┼──────────┬────────┤
 size     │ diff  │ size     │ diff   │ path
──────────┼───────┼──────────┼────────┼────────────────────────
  2.8 KiB │ -30 B │   11 KiB │ -176 B │ ∆ AndroidManifest.xml
  2.4 KiB │  -4 B │  2.3 KiB │    0 B │ ∆ res/1I.9.png
  1.2 KiB │  +1 B │  1.3 KiB │    0 B │ ∆ META-INF/CERT.RSA
   13 KiB │  -1 B │ 28.3 KiB │    0 B │ ∆ META-INF/MANIFEST.MF
──────────┼───────┼──────────┼────────┼────────────────────────
 19.3 KiB │ -34 B │ 42.9 KiB │ -176 B │ (total)


======================
====   MANIFEST   ====
======================

                       │ old                    │ new
───────────────────────┼────────────────────────┼────────────────────────
 package               │ io.goooler.demoapp.app │ io.goooler.demoapp.app
 version code          │ 109000                 │ 109000
 version name          │ 1.9.0                  │ 1.9.0
 uses-permission count │ 14                     │ 13

@@ -18,5 +18,2 @@
   <uses-permission
-      android:name="android.permission.MOUNT_UNMOUNT_FILESYSTEM"
-      />
-  <uses-permission
       android:name="android.permission.ACCESS_NETWORK_STATE"

@Goooler Goooler force-pushed the support-diff-permission-num branch from 6e59634 to 7d4727c Compare April 30, 2024 09:39
There might be significant differences in blame attribution for AndroidManifest.xml. We usually pay close attention to changes in versionCode, targetSdk, and the count of uses-permissions. Adding an extra line to display the result.
@Goooler Goooler force-pushed the support-diff-permission-num branch from 7d4727c to 6b1a967 Compare April 30, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant