Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved development mapping library integrations #127

Merged
merged 1 commit into from
Dec 9, 2023
Merged

feat: improved development mapping library integrations #127

merged 1 commit into from
Dec 9, 2023

Conversation

morehawes
Copy link
Contributor

This PR includes the following improvements to the development/ app:

  • Add labels to identify each mapping library
  • Use OSM tiles for MapLibre
  • Removed unused accessToken parameter for initMapLibre()
  • Load MapLibre CSS
  • Adjusted some map zooms so they all match
  • As a backup, load Google Maps using empty API key none provided (map loads, but displays warning)
  • As a backup, load MapBox GL using an invalid token and use OSM tiles if no access token provided (loads map, but console errors)

This PR includes the following improvements to the development/ app:

- Add labels to identify each mapping library
- Use OSM tiles for MapLibre
- Removed unused accessToken parameter for initMapLibre()
- Load MapLibre CSS
- Adjusted some map zooms so they all match
- As a backup, load Google Maps using empty API key none provided (map loads, but displays warning)
- As a backup, load MapBox GL using an invalid token and use OSM tiles if no access token provided (loads map, but console errors)
Copy link
Owner

@JamesLMilner JamesLMilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@JamesLMilner JamesLMilner merged commit 2537dc7 into JamesLMilner:main Dec 9, 2023
1 check passed
@morehawes morehawes deleted the pr-5 branch December 9, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants