fix: listen for google maps key events on document, not map container #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #129.
Google Maps was not picking up keyboard events ("keyup"/"keydown"). This change listens for keyboard events on the entire document, instead of the map container.
This means keyboard deletion is now working for Google Maps.
The only unintended consequence that I can think of is if there are multiple Terra Draw instances, both would respond to these events.
For example, in the
development/
app if you have a Feature selected in Google Maps and then switch to another Map and select/delete a feature it will also pick up the keyboard event and delete it from the GM map also.