[styles] allow updates of font elements #1153
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this SO. If
update = TRUE
all non empty font elements will be overwritten. At the moment it is not possible to set a font element to missing. All elements are initialized with either""
or some value. Might need some additional thinkingTip
I'm lacking a bit the motivation to work on this. Maybe someone else wants to pick it up.
Issues I see that I wanted to work on or at least get checked prior to merging:
numfmts
only has numfmts,fill
has various other options, what about cell styles in general?""
to "trick"update
into not using the default values. At the moment I do not see any better solution other than changing the default arguments of the function toNULL
and do some further work on the fonts code and I'm not sure I like that. How else should the function know, if the font name to use is the actual default value or the value that we want after updating.fmt_txt()
strings. These will remain in their own color, because the color is embedded in the XML string of the string, not of the cell format. Should we warn?