[misc] attemt to reduce the number of variables in cc
#1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unfortunately I have no idea why it is failing and this worries me a bit. In !interactive() sessions the assigned "" becomes "1" for some reason. Unless explicitly resized to a matching length. Maybe moving the cc creating Rcpp part from Rcpp::wrap() into it's own custom function, had a more hidden impact.
JanMarvin
force-pushed
the
trim_cc_variables
branch
from
5529999 to
27048da
Compare
Merge branch 'trim_cc_variables' of github.com:JanMarvin/openxlsx2 into trim_cc_variables # Conflicts: # R/write.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should create
ccwithc_cm,c_ph, andc_vmonly if they are required bywb_load(). We do not modify these fields, apart fromc_cmin cm formulas.For whatever kind of reason the shared formulas test is failing localy. Returns
"1"when we expect"". At the moment I have no idea why. We modify this cell in our R code and it works if I run it in an interactive session. Still this might indicate an issue somewhere else.