Skip to content

Commit

Permalink
build: fix build failure installing nfpm
Browse files Browse the repository at this point in the history
Before this fix we used the bin/get-github-release.go script to
install nfpm.

However this script fails scraping the downloads page when the target
has more than a few download options. The alternative would be using
the GitHub API but this needs authentication so as not to be rate
limited on GitHub actions.

This patch switches over to go install which is less efficient but
should work in all circumstances.
  • Loading branch information
ncw committed Jun 7, 2023
1 parent 51a468b commit 5a84a08
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ build_dep:

# Get the release dependencies we only install on linux
release_dep_linux:
go run bin/get-github-release.go -extract nfpm goreleaser/nfpm 'nfpm_.*_Linux_x86_64\.tar\.gz'
go install github.com/goreleaser/nfpm/v2/cmd/nfpm@latest

# Get the release dependencies we only install on Windows
release_dep_windows:
Expand Down

0 comments on commit 5a84a08

Please sign in to comment.