Fix shutter discovery message regression from v14.4.1 (arendst#22730)

Jason2866 · Jan 2, 2025 · d5d757f · d5d757f
1 parent b5c326d
commit d5d757f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ All notable changes to this project will be documented in this file.
 ### Changed
 
 ### Fixed
+- Shutter discovery message regression from v14.4.1 (#22730)
 
 ### Removed
 

diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -138,6 +138,7 @@ The latter links can be used for OTA upgrades too like ``OtaUrl https://ota.tasm
 - HASPmota support for `tabview` [#22707](https://github.com/arendst/Tasmota/issues/22707)
 
 ### Fixed
+- Shutter discovery message regression from v14.4.1 [#22730](https://github.com/arendst/Tasmota/issues/22730)
 - Webcam compilation with `define USE_WEBCAM` but without `define ENABLE_RTSPSERVER` [#22686](https://github.com/arendst/Tasmota/issues/22686)
 - Berry Zigbee fix wrong attributes [#22684](https://github.com/arendst/Tasmota/issues/22684)
 - Berry walrus operator [#22685](https://github.com/arendst/Tasmota/issues/22685)

diff --git a/tasmota/tasmota_xdrv_driver/xdrv_27_esp32_shutter.ino b/tasmota/tasmota_xdrv_driver/xdrv_27_esp32_shutter.ino
@@ -2383,7 +2383,7 @@ bool Xdrv27(uint32_t function)
         }
         break;
       case FUNC_JSON_APPEND:
-        if (!ShutterGlobal.sensor_data_reported || TasmotaGlobal.tele_period == 0) {
+        if (!ShutterGlobal.sensor_data_reported || TasmotaGlobal.tele_period != 2) {          
           ShutterGlobal.sensor_data_reported = true;
           for (uint8_t i = 0; i < TasmotaGlobal.shutters_present; i++) {
             ResponseAppend_P(",");

diff --git a/tasmota/tasmota_xdrv_driver/xdrv_27_shutter.ino b/tasmota/tasmota_xdrv_driver/xdrv_27_shutter.ino
@@ -1974,7 +1974,7 @@ bool Xdrv27(uint32_t function)
         }
         break;
       case FUNC_JSON_APPEND:
-        if (!sensor_data_reported || TasmotaGlobal.tele_period == 0) {
+        if (!sensor_data_reported || TasmotaGlobal.tele_period != 2) {
           sensor_data_reported = true;
           for (uint8_t i = 0; i < TasmotaGlobal.shutters_present; i++) {
             uint8_t position = ShutterRealToPercentPosition(Shutter[i].real_position, i);