Skip to content

Commit

Permalink
postcopy: drop ram_pages parameter from postcopy_ram_incoming_init()
Browse files Browse the repository at this point in the history
Not needed. Don't expose last_ram_page().

Signed-off-by: David Hildenbrand <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
  • Loading branch information
davidhildenbrand authored and Juan Quintela committed Jun 27, 2018
1 parent 35374cb commit c136180
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1930,7 +1930,7 @@ static ram_addr_t find_ram_offset(ram_addr_t size)
return offset;
}

unsigned long last_ram_page(void)
static unsigned long last_ram_page(void)
{
RAMBlock *block;
ram_addr_t last = 0;
Expand Down
1 change: 0 additions & 1 deletion include/exec/ram_addr.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ static inline unsigned long int ramblock_recv_bitmap_offset(void *host_addr,
}

long qemu_getrampagesize(void);
unsigned long last_ram_page(void);
RAMBlock *qemu_ram_alloc_from_file(ram_addr_t size, MemoryRegion *mr,
bool share, const char *mem_path,
Error **errp);
Expand Down
4 changes: 2 additions & 2 deletions migration/postcopy-ram.c
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ static int cleanup_range(const char *block_name, void *host_addr,
* postcopy later; must be called prior to any precopy.
* called from arch_init's similarly named ram_postcopy_incoming_init
*/
int postcopy_ram_incoming_init(MigrationIncomingState *mis, size_t ram_pages)
int postcopy_ram_incoming_init(MigrationIncomingState *mis)
{
if (qemu_ram_foreach_migratable_block(init_range, NULL)) {
return -1;
Expand Down Expand Up @@ -1265,7 +1265,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState *mis)
return false;
}

int postcopy_ram_incoming_init(MigrationIncomingState *mis, size_t ram_pages)
int postcopy_ram_incoming_init(MigrationIncomingState *mis)
{
error_report("postcopy_ram_incoming_init: No OS support");
return -1;
Expand Down
2 changes: 1 addition & 1 deletion migration/postcopy-ram.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ int postcopy_ram_enable_notify(MigrationIncomingState *mis);
* postcopy later; must be called prior to any precopy.
* called from ram.c's similarly named ram_postcopy_incoming_init
*/
int postcopy_ram_incoming_init(MigrationIncomingState *mis, size_t ram_pages);
int postcopy_ram_incoming_init(MigrationIncomingState *mis);

/*
* At the end of a migration where postcopy_ram_incoming_init was called.
Expand Down
4 changes: 1 addition & 3 deletions migration/ram.c
Original file line number Diff line number Diff line change
Expand Up @@ -3564,9 +3564,7 @@ static int ram_load_cleanup(void *opaque)
*/
int ram_postcopy_incoming_init(MigrationIncomingState *mis)
{
unsigned long ram_pages = last_ram_page();

return postcopy_ram_incoming_init(mis, ram_pages);
return postcopy_ram_incoming_init(mis);
}

/**
Expand Down

0 comments on commit c136180

Please sign in to comment.