Skip to content

Commit

Permalink
16606 Added invalid NR dialog (bcgov#670)
Browse files Browse the repository at this point in the history
* - app version = 5.9.10
- imported latest shared CorrectName component
- imported latest shared mixins
- renamed NameRequestInvalidErrorDialog -> InvalidIncorpAppDialog
- added dialog to ResultingBusinessName
- added dialog to BusinessName
- added missing parameters to validate method in BusinessName
- created NameRequestErrorDialog
- created unit test suite
- misc cleanup

* - imported latest shared correct-name component
- import latest shared mixins
- renamed InvalidIncorpAppDialog -> InvalidFilingDialog
- renamed InvalidFilingDialog -> FilingNotExistDialog
- imported misc enums directly from shared repo
- used Name Request Error dialog for File and Pay fetch error
- after File and Pay NR error, leave user in Create UI
- cleaned up NR processing in App.vue
- added NR action code check in App.vue
- on resume, check if NR is consumable after storing it
- moved fetch error logic from service to to components
- cleaned up NR processing in Actions.vue
- generalized the text in File and Pay NR dialog
- added spacer to move dialog button to right side
- fixed misc dialog styling
- updated unit tests

---------

Co-authored-by: Severin Beauvais <[email protected]>
  • Loading branch information
severinbeauvais and Severin Beauvais authored Mar 26, 2024
1 parent 28766d6 commit 222a701
Show file tree
Hide file tree
Showing 26 changed files with 783 additions and 575 deletions.
76 changes: 45 additions & 31 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "5.9.9",
"version": "5.9.10",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand All @@ -23,7 +23,7 @@
"@bcrs-shared-components/confirm-dialog": "1.2.1",
"@bcrs-shared-components/contact-info": "1.2.15",
"@bcrs-shared-components/corp-type-module": "1.0.15",
"@bcrs-shared-components/correct-name": "1.0.42",
"@bcrs-shared-components/correct-name": "1.0.46",
"@bcrs-shared-components/court-order-poa": "3.0.11",
"@bcrs-shared-components/date-picker": "1.2.15",
"@bcrs-shared-components/document-delivery": "1.2.0",
Expand All @@ -35,7 +35,7 @@
"@bcrs-shared-components/interfaces": "1.1.5",
"@bcrs-shared-components/jurisdiction": "1.0.1",
"@bcrs-shared-components/limited-restoration-panel": "1.0.5",
"@bcrs-shared-components/mixins": "1.1.34",
"@bcrs-shared-components/mixins": "1.1.39",
"@bcrs-shared-components/nature-of-business": "1.2.14",
"@bcrs-shared-components/relationships-panel": "1.0.9",
"@bcrs-shared-components/staff-comments": "1.3.15",
Expand Down
Loading

0 comments on commit 222a701

Please sign in to comment.