DECREF before return, not always.

JelleZijlstra · Jun 5, 2023 · 0307832 · 0307832
1 parent 517bd0d
commit 0307832
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Objects/descrobject.c b/Objects/descrobject.c
@@ -1802,8 +1802,8 @@ property_init_impl(propertyobject *self, PyObject *fget, PyObject *fset,
             // See PropertySubclassTest.test_slots_docstring_copy_exception.
             int err = PyObject_SetAttr(
                         (PyObject *)self, &_Py_ID(__doc__), prop_doc);
-            Py_DECREF(prop_doc);
             if (err < 0) {
+                Py_DECREF(prop_doc);  // release our new reference.
                 return -1;
             }
         }