Apply suggestions from code review

Co-authored-by: Victor Stinner <[email protected]>
JelleZijlstra · Sep 24, 2024 · ab30124 · ab30124
1 parent fefa126
commit ab30124
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Lib/annotationlib.py b/Lib/annotationlib.py
@@ -296,9 +296,10 @@ def __convert_to_ast(self, other):
             return ast.Constant(value=other)
 
     def __get_ast(self):
-        if isinstance(self.__ast_node__, str):
-            return ast.Name(id=self.__ast_node__)
-        return self.__ast_node__
+        node = self.__ast_node__
+        if isinstance(node, str):
+            return ast.Name(id=node)
+        return node
 
     def __make_new(self, node):
         return _Stringifier(

diff --git a/Lib/test/test_annotationlib.py b/Lib/test/test_annotationlib.py
@@ -282,7 +282,8 @@ class Gen[T]:
     def test_fwdref_with_module(self):
         self.assertIs(ForwardRef("Format", module="annotationlib").evaluate(), Format)
         self.assertIs(
-            ForwardRef("Counter", module="collections").evaluate(), collections.Counter
+            ForwardRef("Counter", module="collections").evaluate(),
+            collections.Counter
         )
         self.assertEqual(
             ForwardRef("Counter[int]", module="collections").evaluate(),