Forward-port typing-extensions change

JelleZijlstra · Nov 29, 2023 · d528dc8 · d528dc8
1 parent e60ad5c
commit d528dc8
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/Lib/test/test_warnings/__init__.py b/Lib/test/test_warnings/__init__.py
@@ -1634,6 +1634,21 @@ def d():
             py_warnings.simplefilter("error")
             d()
 
+    def test_only_strings_allowed(self):
+        with self.assertRaisesRegex(
+            TypeError,
+            "Expected an object of type str for 'msg', not 'type'"
+        ):
+            @deprecated
+            class Foo: ...
+
+        with self.assertRaisesRegex(
+            TypeError,
+            "Expected an object of type str for 'msg', not 'function'"
+        ):
+            @deprecated
+            def foo(): ...
+
 
 def setUpModule():
     py_warnings.onceregistry.clear()

diff --git a/Lib/warnings.py b/Lib/warnings.py
@@ -557,6 +557,10 @@ def __init__(
         category: type[Warning] | None = DeprecationWarning,
         stacklevel: int = 1,
     ) -> None:
+        if not isinstance(msg, str):
+            raise TypeError(
+                f"Expected an object of type str for 'msg', not {type(msg).__name__!r}"
+            )
         self.msg = msg
         self.category = category
         self.stacklevel = stacklevel