Add HamlLint integration test

This caught one thing we forgot to change in the previous refactor.

Also, extract the common test bolierplate into a shared example.

.rspec

@@ -0,0 +1 @@
+--require spec_helper

lib/jobs/haml_review_job.rb

@@ -10,7 +10,7 @@ def self.perform(attributes)
     Runner.call(
       attributes: attributes,
       linter_class: Linters::HamlLint::Linter,
-      config_filename: "haml.yml",
+      default_config_filename: "haml.yml",
     )
   end
 end

lib/runner.rb

@@ -7,7 +7,7 @@ def self.call(*args)
     new(*args).call
   end
 
-  # This job receives the following arguments
+  # The attributes are passed from the job and contain the following:
   # - filename
   # - content
   # - config
@@ -48,7 +48,7 @@ def complete_file_review(violations)
     Resque.enqueue(
       CompletedFileReviewJob,
       commit_sha: attributes.fetch("commit_sha"),
-      filename: file.path,
+      filename: attributes.fetch("filename"),
       patch: attributes.fetch("patch"),
       pull_request_number: attributes.fetch("pull_request_number"),
       violations: violations,

spec/lib/jobs/haml_review_job_spec.rb

@@ -0,0 +1,15 @@
+require "jobs/haml_review_job"
+
+RSpec.describe HamlReviewJob do
+  it_behaves_like(
+    "a linter",
+    content: "%div\n  #main",
+    filename: "test.haml",
+    violations: [
+      {
+        line: 2,
+        message: "Files should end with a trailing newline",
+      }
+    ],
+  )
+end

spec/lib/jobs/scss_review_job_spec.rb

@@ -0,0 +1,12 @@
+require "jobs/scss_review_job"
+
+RSpec.describe ScssReviewJob do
+  it_behaves_like(
+    "a linter",
+    content: "$color: #aaa\n",
+    filename: "test.scss",
+    violations: [
+      { line: 1, message: "Declaration should be terminated by a semicolon" }
+    ],
+  )
+end

spec/spec_helper.rb

@@ -1,6 +1,8 @@
+$: << File.expand_path(".")
+
 require "byebug"
 
-$: << File.expand_path(".")
+Dir["./spec/support/**/*.rb"].sort.each { |file| require file }
 
 ENV["RACK_ENV"] = "test"
 ENV["REDIS_URL"] = "redis://rediswoohoo:[email protected]:12345/"

spec/support/shared_examples/linter.rb

@@ -0,0 +1,23 @@
+RSpec.shared_examples "a linter" do |args|
+  it "enqueues a job with violations" do
+    attributes = {
+      "filename" => args.fetch(:filename),
+      "content" => args.fetch(:content),
+      "commit_sha" => "anything",
+      "patch" => "",
+      "pull_request_number" => "1",
+    }
+    allow(Resque).to receive(:enqueue)
+
+    described_class.perform(attributes)
+
+    expect(Resque).to have_received(:enqueue).with(
+      CompletedFileReviewJob,
+      commit_sha: attributes["commit_sha"],
+      filename: attributes["filename"],
+      patch: attributes["patch"],
+      pull_request_number: attributes["pull_request_number"],
+      violations: args.fetch(:violations),
+    )
+  end
+end