Skip to content

Commit

Permalink
Merge branch 'release/4.0.0'
Browse files Browse the repository at this point in the history
  • Loading branch information
Jericho committed May 31, 2018
2 parents 99620cd + d52b457 commit 8bfd555
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
8 changes: 7 additions & 1 deletion Source/Picton.Messaging/AsyncMessagePump.cs
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,13 @@ public void Stop()
if (isPoison)
{
// PLEASE NOTE: we use "CancellationToken.None" to ensure a processed message is deleted from the queue and moved to poison queue even when the message pump is shutting down
if (_poisonQueueManager != null) await _poisonQueueManager.AddMessageAsync(message.Content, null, null, null, null, CancellationToken.None).ConfigureAwait(false);
if (_poisonQueueManager != null)
{
message.Metadata["PoisonExceptionMessage"] = ex.GetBaseException().Message;
message.Metadata["PoisonExceptionDetails"] = ex.GetBaseException().ToString();

await _poisonQueueManager.AddMessageAsync(message.Content, message.Metadata, null, null, null, null, CancellationToken.None).ConfigureAwait(false);
}
await _queueManager.DeleteMessageAsync(message, null, null, CancellationToken.None).ConfigureAwait(false);
}
}
Expand Down
10 changes: 5 additions & 5 deletions Source/Picton.Messaging/Picton.Messaging.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@

<ItemGroup>
<PackageReference Include="App.Metrics" Version="2.1.0" />
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.0.4" />
<PackageReference Include="Picton" Version="3.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.1.0" />
<PackageReference Include="Picton" Version="4.0.0" />
<PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
<PrivateAssets>All</PrivateAssets>
</PackageReference>
Expand All @@ -40,7 +40,7 @@
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' != 'net452'">
<PackageReference Include="Microsoft.CSharp" Version="4.4.1" />
<PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
</ItemGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'net452' ">
Expand All @@ -56,11 +56,11 @@
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="$(SolutionDir)\stylecop.json" Link="stylecop.json" />
<AdditionalFiles Include="$(SolutionDir)stylecop.json" Link="stylecop.json" />
</ItemGroup>

<PropertyGroup>
<CodeAnalysisRuleSet>$(SolutionDir)\StyleCopRules.ruleset</CodeAnalysisRuleSet>
<CodeAnalysisRuleSet>$(SolutionDir)StyleCopRules.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>

</Project>

0 comments on commit 8bfd555

Please sign in to comment.