Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSpark does not provide any feedback if a client sends an inappropriate request via a per-test textbox after tests generation via LLM #95

Conversation

arksap2002
Copy link
Collaborator

@arksap2002 arksap2002 commented Dec 15, 2023

Description of changes made

How to reproduce:
Generate some tests using LLM.
Navigate to any test in the TestSpark sidebar and inside its textbox write any unrelated request (e.g. "What is the life story of Nyan Cat?", "rewrite the code of this test in JavaScript") and send it.
After the request is sent and processed there is no feedback about the request being inappropriate to the generated test.
Note: no crush occurs, just no feedback provided.

What is expected:
Probably, some warning notification that a request is inappropriate.

Other notes

Closes ICTL-839

  • I have checked that I am merging into correct branch

Copy link
Collaborator

@pderakhshanfar pderakhshanfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the error message tho

src/main/resources/messages/TestSpark.properties Outdated Show resolved Hide resolved
@arksap2002 arksap2002 merged commit 77d9684 into development Jan 8, 2024
3 checks passed
@arksap2002 arksap2002 deleted the arksap2002/improvements/handling-an-inconclusive-request branch January 8, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants