fix!: EXPOSED-569 groupConcat uses wrong SQLite syntax & ignores DIST…

…INCT in

Oracle & SQL Server

- Fixed wrong function name in exception message
- Change to use appendTo() with prefix

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/Function.kt

@@ -113,8 +113,7 @@ class Concat(
 }
 
 /**
- * Represents an SQL function that concatenates the text representation of all non-null input values of each group
- * from [expr], separated by [separator].
+ * Represents an SQL function that concatenates the text representation of all non-null input values of each group from [expr], separated by [separator]
  */
 class GroupConcat<T : String?>(
     /** Returns grouped expression being concatenated. */

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/OracleDialect.kt

@@ -121,7 +121,7 @@ internal object OracleFunctionProvider : FunctionProvider() {
         queryBuilder: QueryBuilder
     ): Unit = queryBuilder {
         val tr = TransactionManager.current()
-        if (expr.distinct) tr.throwUnsupportedException("Oracle doesn't support DISTINCT in STRING_AGG")
+        if (expr.distinct) tr.throwUnsupportedException("Oracle doesn't support DISTINCT in LISTAGG")
         if (expr.orderBy.size > 1) {
             tr.throwUnsupportedException("Oracle supports only single column in ORDER BY clause in LISTAGG")
         }

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/SQLiteDialect.kt

@@ -56,8 +56,7 @@ internal object SQLiteFunctionProvider : FunctionProvider() {
                 +", '$it'"
             }
             if (expr.orderBy.isNotEmpty()) {
-                +" ORDER BY "
-                expr.orderBy.appendTo { (expression, sortOrder) ->
+                expr.orderBy.appendTo(prefix = " ORDER BY ") { (expression, sortOrder) ->
                     currentDialect.dataTypeProvider.precessOrderByClause(this, expression, sortOrder)
                 }
             }