-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for datetime with timezone #1079
Conversation
HI there, I googled how to retrigger a new pipeline in Teamcity after adding a new commit to my existing pull request but it doesn't seem to work. Early comments on the PR welcome as well. |
Hi @alsofr , the build will be triggered automatically after Teamcity will see your changes and free agent is available. As I can see from the build log the ":exposed-java-time:test" task fails with |
Thanks for your answer, the build indeed retriggered, but several hours later. I'm suspecting a difference between h2 running on mac osx vs linux because it works on my machine ™️ :). |
Hi again @Tapac , 12 hours later and still no build triggered for my 2 new commits. Is that expected? |
I've run build and reinstall GitHub webhook, I hope it will help. |
Replaced the lower case HH:mm (meaning optional minutes) with upper case HH:MM and another optional timezone of format +HH
@Tapac the issue with TeamCity persists, the new commit doesn't trigger a new pipeline run in Teamcity. |
Hi there, a review would be appreciated. |
Hi again, sorry to insist but could i get a review on this code please? @Tapac ? |
HI @Tapac , |
any update on this? why wasnt it merged? DateTime with TimeZone is really common feature @Tapac |
Introduce a separate new datetimetz type
Existing datetime field was left untouched to avoid backward incompatibilities issues.
MySQL doesn't actually have support for the type so a dummy/incomplete implementation was done.