Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for datetime with timezone #1079

Closed
wants to merge 10 commits into from

Conversation

alsofr
Copy link

@alsofr alsofr commented Oct 24, 2020

Introduce a separate new datetimetz type

Existing datetime field was left untouched to avoid backward incompatibilities issues.

MySQL doesn't actually have support for the type so a dummy/incomplete implementation was done.

@alsofr alsofr marked this pull request as draft October 24, 2020 22:43
@alsofr alsofr changed the title Add support for datetime with timezone Add support for datetime with timezone Oct 24, 2020
@alsofr
Copy link
Author

alsofr commented Oct 24, 2020

HI there, I googled how to retrigger a new pipeline in Teamcity after adding a new commit to my existing pull request but it doesn't seem to work.
The original build failed (but works locally) and I can't find any useful information in the logs (which database causes it to fail?).
@Tapac is this possible or do I need to create a new pull request every time I have changes?
Thanks in advance.

Early comments on the PR welcome as well.

@Tapac
Copy link
Contributor

Tapac commented Oct 25, 2020

Hi @alsofr , the build will be triggered automatically after Teamcity will see your changes and free agent is available.

As I can see from the build log the ":exposed-java-time:test" task fails with Invalid zone offset pattern: +HH:mm:ss exception.
You can try to run that task locally and check will it pass or not.

@alsofr
Copy link
Author

alsofr commented Oct 25, 2020

Thanks for your answer, the build indeed retriggered, but several hours later.

I'm suspecting a difference between h2 running on mac osx vs linux because it works on my machine ™️ :).

@alsofr
Copy link
Author

alsofr commented Oct 26, 2020

Hi again @Tapac , 12 hours later and still no build triggered for my 2 new commits. Is that expected?

@Tapac
Copy link
Contributor

Tapac commented Oct 26, 2020

I've run build and reinstall GitHub webhook, I hope it will help.

Replaced the lower case HH:mm (meaning optional minutes) with upper
case HH:MM and another optional timezone of format +HH
@alsofr
Copy link
Author

alsofr commented Nov 1, 2020

@Tapac the issue with TeamCity persists, the new commit doesn't trigger a new pipeline run in Teamcity.

@alsofr alsofr marked this pull request as ready for review November 1, 2020 10:32
@alsofr
Copy link
Author

alsofr commented Nov 6, 2020

Hi there, a review would be appreciated.
@Tapac maybe ?

@alsofr
Copy link
Author

alsofr commented Nov 19, 2020

Hi again, sorry to insist but could i get a review on this code please? @Tapac ?

@tim-fdc
Copy link

tim-fdc commented Jan 19, 2021

HI @Tapac ,
any news about this PR? We really need more time support.
Best
Tim

@dvorsky
Copy link

dvorsky commented Sep 16, 2021

any update on this? why wasnt it merged? DateTime with TimeZone is really common feature @Tapac

@joc-a
Copy link
Collaborator

joc-a commented Jul 27, 2023

Hey @alsofr. Thank you for your contribution. This feature has now been implemented here #1787.

@joc-a joc-a closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants