Add timezone to DateTime column type #109
Conversation
| else | ||
| "'${DEFAULT_DATE_STRING_FORMATTER.print(dateTime)}'" | ||
| } | ||
|
|
||
| override fun valueFromDB(value: Any): Any = when(value) { | ||
| is DateTime -> value |
There was a problem hiding this comment.
The only "non-obvious" change this makes is that the returned instance is the same one, but in all other branches we create a new DateTime object. Not sure if that behavior needs to be preserved or not.
There was a problem hiding this comment.
Looks like upstream has changed this as well
|
I was also tempted to add a |
|
Is this project accepting contributions? This PR has been opened for a month, but there is not a single comment on it (besides @msrd0, thanks again). |
|
I once had a PR merged, but I haven't read a single comment from the developers, neither on PRs nor on issues |
|
@Arcnor Could you please provide an example where |
|
Would it make sense to fix the conflicts and merge this pull request? There still isn't any support for the date time with timezone Postgres type. I don't really understand the concept of datetime without timezone, what is the use case for this? |
This PR basically adds timezone for the
DATETIMEtype on all supported DBs. It also fixes at least a bug when retrieving a DateTime type from the DB (it tries to convert aDateTimeto aDateTimeby parsing it through the formatter, but it fails when doing so. Also, this is obviously not necessary)