fix: EXPOSED-135 Oracle does not use setSchema value as currentScheme #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following test fails when run on Oracle: CreateIndexTests/'test possibility to create indexes when table exists in different schemas'() Fails with 'ORA-01430: column being added already exists in table' due to this statement being incorrectly generated: ALTER TABLE TEST_TABLE ADD ID NUMBER(12) NOT NULL This happens because metadata returns an empty map of existing table ColumnMetadata when columns() is invoked in JdbcDatabaseMetadataImpl. getColumns() relies on the value of currentScheme which is invariably set to return databaseName in Oracle; that is, the default user set up at connection, EXPOSEDTEST. So, even though a correct statement is executed, which changes schema in the DB, Exposed is using the default schema to query metadata. currentScheme now attempts to get a connection schema first before using databaseName.
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…JetBrains#1828) The following test fails when run on Oracle: CreateIndexTests/'test possibility to create indexes when table exists in different schemas'() Fails with 'ORA-01430: column being added already exists in table' due to this statement being incorrectly generated: ALTER TABLE TEST_TABLE ADD ID NUMBER(12) NOT NULL This happens because metadata returns an empty map of existing table ColumnMetadata when columns() is invoked in JdbcDatabaseMetadataImpl. getColumns() relies on the value of currentScheme which is invariably set to return databaseName in Oracle; that is, the default user set up at connection, EXPOSEDTEST. So, even though a correct statement is executed, which changes schema in the DB, Exposed is using the default schema to query metadata. currentScheme now attempts to get a connection schema first before using databaseName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test fails when run on Oracle:
CreateIndexTests/'test possibility to create indexes when table exists in different schemas'()
Fails with:
This happens because metadata incorrectly returns an empty map of existing table columns when
columns()is invoked inJdbcDatabaseMetadataImpl:metadata.getColumns()relies on the propertycurrentScheme, which is invariably set todatabaseNamein Oracle; that means, it is set to the default user created at connection, EXPOSEDTEST.So, even though this correct SQL is executed (which correctly changes the schema internally in the DB):
Exposed continues to use the default schema, EXPOSEDTEST, as the argument when querying metadata.
Commit 920428b shows a similar change, but only done local to a single function.