fix: EXPOSED-145 Quoted table name breaks CREATE SEQUENCE in Oracle #1836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a table with an auto-increment column is created in Oracle, a sequence must be created first.
If the provided table name has escaped double quotes, this CREATE SEQUENCE statement throws a syntax error:
In the case of all the
IdTable
subclasses, this happens becauseautoincrement()
on the id column is not being provided a custom name, so thefallbackSeqName
string is being used. This string now removes double quotes from a table name.Note:
Oracle (and H2 Oracle) are the only DB that rely on
fallbackSeqName
as they are the only supported DB that haveneedsSequenceToAutoInc == true
: