fix: Verbose logging introduced by LogCaptor

[joc-a]

Adding the LogCaptor dependency caused the logging level to be DEBUG instead of INFO, even though it is configured to be INFO in log4j2.xml. This is a known issue (Hakky54/log-captor#8) because LogCaptor uses a different appender than the one configured in log4j2.xml. More details in this comment: Hakky54/log-captor#8 (comment).

The solution is to remove the dependency and create a custom appender which is used to test the logs.

Partially inspired by this.

[Hakky54]

@joc-a there is a solution for the issue you are facing. You can have logcaptor and mute all of the logs in the console or build output and still do the assertions. I use the following test resource which you can copy over https://github.com/Hakky54/sslcontext-kickstart/blob/master/sslcontext-kickstart/src/test/resources/logback-test.xml

I was waiting for your input on the issue you created here Hakky54/log-captor#47
However it seems like you already was working on a workaround with a native implementation with log4j2

Do you think it is worth to give it a shot with the logback-test.xml file?

[joc-a]

Hey @Hakky54. Thank you for your suggestion. I did try that solution at first after searching through the issues on GitHub, but it won't work for this case because it would completely mute all logs, including those that we would expect to see if there is something being logged that should not be there. I wanted the logging behaviour to be exactly the same as before introducing LogCaptor, meaning that if a bug is reintroduced that causes unwanted logging, we should be able to catch it both by the assertion in the test and by seeing the it in the console.

[Hakky54]

I think it should be possible, if you are ok I would like to give it a shot. Can you point out which logs you still want to see and which should not appear?

[joc-a]

@Hakky54 If you change this line here to this fun <T> getOrNull(expression: Expression<T>): T? = if (hasValue(expression)) get(expression) else null, you should be able to see a warning in the console when running this test testNoWarningsOnLeftJoinRegression.

WARN Test worker Exposed:getInternal:57 - Column jointable.dataCol is marked as not null, has default db value, but returns null. Possible have to re-read it from DB.

This should be the only warning with nothing else.
If I keep the LogCaptor dependency and add the logback-test.xml as you suggested, I would no longer see that warning in the console.

[e5l]

Please check #1852, it looks much simpler

[joc-a]

Closing this in favour of #1852