chore: Reuse Containers in tests; Add Test parameters #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
force-pushed
the
e5l/buildscripts
branch
2 times, most recently
from
4935aab
to
0b12665
Compare
|
Failed after rebase, will take a look |
e5l
force-pushed
the
e5l/buildscripts
branch
from
0b12665
to
dc8009a
Compare
|
Fixed |
bog-walk
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Other than the comments about MariaDB and SQL Server:
- Can confirm that
startComposeandstopComposework as expected on my end. - Gradle task
testbehaves a little different now in that it runs all tests in all files in all databases.- Would it be possible to have a task to run a single test (or a single test file) using all databases at once? Or maybe I missed a way?
- Having the database and dialect as part of the test name in the Test runner tab is going to be so helpful! 😄
Very excited for this PR! ❤️
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/Database.kt
Outdated
Show resolved
Hide resolved
exposed-java-time/src/test/kotlin/org/jetbrains/exposed/DefaultsTest.kt
Outdated
Show resolved
Hide resolved
exposed-tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/shared/ddl/CreateDatabaseTest.kt
Outdated
Show resolved
Hide resolved
...-tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/shared/functions/MathFunctionTests.kt
Outdated
Show resolved
Hide resolved
|
@bog-walk, yep. I've noticed it's starting to be slightly different with |
e5l
force-pushed
the
e5l/buildscripts
branch
2 times, most recently
from
8d6d01e
to
66e4af7
Compare
joc-a
reviewed
Sep 6, 2023
buildSrc/src/main/kotlin/org/jetbrains/exposed/gradle/Versions.kt
Outdated
Show resolved
Hide resolved
|
This is what I get when running For example, |
e5l
force-pushed
the
e5l/buildscripts
branch
from
66e4af7
to
6792bd3
Compare
e5l
force-pushed
the
e5l/buildscripts
branch
from
6792bd3
to
1e27dab
Compare
bog-walk
approved these changes
Sep 8, 2023
|
@e5l This test is failing for me |
joc-a
approved these changes
Sep 12, 2023
|
@joc-a, thanks! fixed |
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
* Make all build scripts indexed, cleanup unused plugin * Update dependencies * Add explicit SERVICE_HOST to avoid network issues with Docker 20.* on linux * Do not log ignored tests * Prevent db containers to restart in tests * Cleanup docker plugin usages * Fix db credentials * Add test name to parameters * Reduce columns iteration time * Reduce date time test time * Migrate to faster oracle container * Force drop table before test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parameters to the test tasks:
container,database, anddialect. It also makes all modules and tests using the same database containers, avoiding starting a new one.Two gradle tasks were introduced:
startCompose,stopCompose. With this 2 tasks you can warmup containers before testing, so no containers will be restarted.