test: Refactor time tests #1880
Conversation
- Move testCurrentDateTimeFunction from JodaTimeDefaultsTest to JodaTimeTests - Rewrite testDefaultCurrentDateTime in JodaTimeDefaultsTest - Add testDefaultCurrentDateTime to Java and Kotlin tests
| get() = | ||
| if (TransactionManager.isInitialized() && TransactionManager.currentOrNull() != null) { | ||
| currentDialectTest | ||
| } else null |
There was a problem hiding this comment.
Not about the PR, but I'm confused about our Detekt GH action.
Based on the MultiLineIfElse setting in detekt-config, shouldn't this line be disallowed? It's flagged in the IDE.
There was a problem hiding this comment.
I would also make an extension for this condition
There was a problem hiding this comment.
Not about the PR, but I'm confused about our Detekt GH action.
Based on the
MultiLineIfElsesetting indetekt-config, shouldn't this line be disallowed? It's flagged in the IDE.
This is in the exposed-tests module, which is excluded in the detekt GitHub action. I do have it on my to-do list to remove all the detekt warnings in that module at some point and include it in the GitHub action, but I'll create an issue for it.
There was a problem hiding this comment.
That's on me. I should've realised that code wasn't a part of any datetime module.
There was a problem hiding this comment.
I would also make an extension for this condition
I'll work on this in the next PR for refactoring some code in the exposed-tests module.
|
LGTM |
testCurrentDateTimeFunctionfromJodaTimeDefaultsTesttoJodaTimeTeststestDefaultCurrentDateTimeinJodaTimeDefaultsTesttestDefaultCurrentDateTimeto Java and Kotlin tests