fix!: EXPOSED-288 Extend ANY and ALL operators to use ArrayColumnType #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Feb 14, 2024
| * | ||
| * @throws IllegalStateException If no column type mapping is found and a [defaultType] is not provided. | ||
| */ | ||
| fun <T : Any> resolveColumnType( |
There was a problem hiding this comment.
we may want to mark it as internal API annotation
There was a problem hiding this comment.
@e5l I agree and I just tried but I remember now why I couldn't.
It's because it's being invoked by inline functions. So setting it to internal shows this compiler failure everywhere:
Public-API inline function cannot access non-public-API 'internal fun resolveColumnType...
Is there any option I'm not seeing? Maybe mark it with a deprecation warning or an annotation to deter public use?
joc-a
approved these changes
Feb 20, 2024
- Support using ANY and ALL operators with array column or expression. - Remove UntypedAndUnsizedArrayColumnType and replace it in AllAnyFromArrayOp with ArrayColumnType. Remove associated unused dialect data types. - Introduce function that resolves a column type based on type reflection. Refactor existing array and json functions to use this, while still having a nullable override.
Fix logic in arrayParam() and arrayLiteral(). Switch tests to use type reflection and update KDocs about nullable arrays.
- Extract unrelated non-breaking changes to another PR - Add missing Exposed column types to resolve and adjust tests
- Fix rebase inconsistency - Update unit test to include arrayParam - Refactor AllAnyFromExpressionOp to not perform resolve column logic
Introduce InternalApi annotation and add it to resolveColumnType(). Move other existing annotation classes to dedicated file.
bog-walk
force-pushed
the
bog-walk/extend-any-all-array
branch
from
5eefbaf
to
af208a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UntypedAndUnsizedArrayColumnTypefrom PR feat: AddALLandANYoperators accepting array, subquery, or table parameters #1886 withArrayColumnTypefrom PR feat: EXPOSED-248 Support array column type #1986resolveColumnType()that returns an appropriate column type based on type reflectionNote This is a potentially breaking change in the (unlikely) event that users were providing an array of non-primitive or unsupported types to
anyFrom()orallFrom(), for example:anyFrom(arrayOf<BigInteger>()). The recommendation will be to provide the best match or custom column type to the new parameter.