Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: EXPOSED-234 Set exposed-crypt to jdk 17 & bump spring-security-crypto to 6.+ #2001

Merged
merged 1 commit into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion exposed-crypt/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
kotlin("jvm") apply true
}
Expand All @@ -7,10 +9,20 @@ repositories {
}

kotlin {
jvmToolchain(8)
jvmToolchain(17)
}

dependencies {
api(project(":exposed-core"))
api(libs.spring.security.crypto)
testImplementation(project(":exposed-dao"))
testImplementation(project(":exposed-tests"))
testImplementation(libs.junit)
testImplementation(kotlin("test-junit"))
}

tasks.withType<KotlinCompile>().configureEach {
kotlinOptions {
jvmTarget = "17"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
package org.jetbrains.exposed.crypt

import org.jetbrains.exposed.dao.id.IntIdTable
import org.jetbrains.exposed.sql.insertAndGetId
import org.jetbrains.exposed.sql.selectAll
import org.jetbrains.exposed.sql.tests.DatabaseTestsBase
import org.jetbrains.exposed.sql.tests.shared.assertEquals
import org.jetbrains.exposed.sql.update
import org.junit.Test
import kotlin.test.assertEquals

class EncryptedColumnTests : DatabaseTestsBase() {
@Test
fun testOutputLengthOfEncryption() {
fun testSize(algorithm: String, encryptor: Encryptor, str: String) =
assertEquals(
encryptor.maxColLength(str.toByteArray().size),
encryptor.encrypt(str).toByteArray().size,
"Failed to calculate length of $algorithm's output."
)

val encryptors = arrayOf(
"AES_256_PBE_GCM" to Algorithms.AES_256_PBE_GCM("passwd", "12345678"),
"AES_256_PBE_CBC" to Algorithms.AES_256_PBE_CBC("passwd", "12345678"),
"BLOW_FISH" to Algorithms.BLOW_FISH("sadsad"),
"TRIPLE_DES" to Algorithms.TRIPLE_DES("1".repeat(24))
)
val testStrings = arrayOf("1", "2".repeat(10), "3".repeat(31), "4".repeat(1001), "5".repeat(5391))

for ((algorithm, encryptor) in encryptors) {
for (testStr in testStrings) {
testSize(algorithm, encryptor, testStr)
}
}
}

@Test
fun testEncryptedColumnTypeWithAString() {
val stringTable = object : IntIdTable("StringTable") {
val name = encryptedVarchar("name", 80, Algorithms.AES_256_PBE_CBC("passwd", "5c0744940b5c369b"))
val city = encryptedBinary("city", 80, Algorithms.AES_256_PBE_GCM("passwd", "5c0744940b5c369b"))
val address = encryptedVarchar("address", 100, Algorithms.BLOW_FISH("key"))
val age = encryptedVarchar("age", 100, Algorithms.TRIPLE_DES("1".repeat(24)))
}

withTables(stringTable) {
val id1 = stringTable.insertAndGetId {
it[name] = "testName"
it[city] = "testCity".toByteArray()
it[address] = "testAddress"
it[age] = "testAge"
}

assertEquals(1L, stringTable.selectAll().count())

assertEquals("testName", stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.name])
assertEquals("testCity", String(stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.city]))
assertEquals("testAddress", stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.address])
assertEquals("testAge", stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.age])
}
}

@Test
fun testUpdateEncryptedColumnType() {
val stringTable = object : IntIdTable("StringTable") {
val name = encryptedVarchar("name", 100, Algorithms.AES_256_PBE_GCM("passwd", "12345678"))
val city = encryptedBinary("city", 100, Algorithms.AES_256_PBE_CBC("passwd", "12345678"))
val address = encryptedVarchar("address", 100, Algorithms.BLOW_FISH("key"))
}

withTables(stringTable) {
val id = stringTable.insertAndGetId {
it[name] = "TestName"
it[city] = "TestCity".toByteArray()
it[address] = "TestAddress"
}

val updatedName = "TestName2"
val updatedCity = "TestCity2"
val updatedAddress = "TestAddress2"
stringTable.update({ stringTable.id eq id }) {
it[name] = updatedName
it[city] = updatedCity.toByteArray()
it[address] = updatedAddress
}

assertEquals(updatedName, stringTable.selectAll().where { stringTable.id eq id }.single()[stringTable.name])
assertEquals(updatedCity, String(stringTable.selectAll().where { stringTable.id eq id }.single()[stringTable.city]))
assertEquals(updatedAddress, stringTable.selectAll().where { stringTable.id eq id }.single()[stringTable.address])
}
}
}
1 change: 0 additions & 1 deletion exposed-tests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ dependencies {
implementation(project(":exposed-core"))
implementation(project(":exposed-jdbc"))
implementation(project(":exposed-dao"))
implementation(project(":exposed-crypt"))

implementation(libs.slf4j)
implementation(libs.log4j.slf4j.impl)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
package org.jetbrains.exposed.sql.tests.shared.dml

import nl.altindag.log.LogCaptor
import org.jetbrains.exposed.crypt.Algorithms
import org.jetbrains.exposed.crypt.encryptedBinary
import org.jetbrains.exposed.crypt.encryptedVarchar
import org.jetbrains.exposed.dao.id.IntIdTable
import org.jetbrains.exposed.sql.*
import org.jetbrains.exposed.sql.tests.DatabaseTestsBase
Expand Down Expand Up @@ -493,30 +490,4 @@ class SelectTests : DatabaseTestsBase() {
assertEquals(0, stringTable.selectAll().where { stringTable.name eq veryLongString }.count())
}
}

@Test
fun testEncryptedColumnTypeWithAString() {
val stringTable = object : IntIdTable("StringTable") {
val name = encryptedVarchar("name", 80, Algorithms.AES_256_PBE_CBC("passwd", "5c0744940b5c369b"))
val city = encryptedBinary("city", 80, Algorithms.AES_256_PBE_GCM("passwd", "5c0744940b5c369b"))
val address = encryptedVarchar("address", 100, Algorithms.BLOW_FISH("key"))
val age = encryptedVarchar("age", 100, Algorithms.TRIPLE_DES("1".repeat(24)))
}

withTables(stringTable) {
val id1 = stringTable.insertAndGetId {
it[name] = "testName"
it[city] = "testCity".toByteArray()
it[address] = "testAddress"
it[age] = "testAge"
}

assertEquals(1L, stringTable.selectAll().count())

assertEquals("testName", stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.name])
assertEquals("testCity", String(stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.city]))
assertEquals("testAddress", stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.address])
assertEquals("testAge", stringTable.selectAll().where { stringTable.id eq id1 }.first()[stringTable.age])
}
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package org.jetbrains.exposed.sql.tests.shared.dml

import org.jetbrains.exposed.crypt.Algorithms
import org.jetbrains.exposed.crypt.encryptedBinary
import org.jetbrains.exposed.crypt.encryptedVarchar
import org.jetbrains.exposed.dao.id.IntIdTable
import org.jetbrains.exposed.dao.id.LongIdTable
import org.jetbrains.exposed.exceptions.UnsupportedByDialectException
Expand Down Expand Up @@ -170,34 +167,4 @@ class UpdateTests : DatabaseTestsBase() {
}
}
}

@Test
fun `update encryptedColumnType`() {
val stringTable = object : IntIdTable("StringTable") {
val name = encryptedVarchar("name", 100, Algorithms.AES_256_PBE_GCM("passwd", "12345678"))
val city = encryptedBinary("city", 100, Algorithms.AES_256_PBE_CBC("passwd", "12345678"))
val address = encryptedVarchar("address", 100, Algorithms.BLOW_FISH("key"))
}

withTables(stringTable) {
val id = stringTable.insertAndGetId {
it[name] = "TestName"
it[city] = "TestCity".toByteArray()
it[address] = "TestAddress"
}

val updatedName = "TestName2"
val updatedCity = "TestCity2"
val updatedAddress = "TestAddress2"
stringTable.update({ stringTable.id eq id }) {
it[name] = updatedName
it[city] = updatedCity.toByteArray()
it[address] = updatedAddress
}

assertEquals(updatedName, stringTable.selectAll().where { stringTable.id eq id }.single()[stringTable.name])
assertEquals(updatedCity, String(stringTable.selectAll().where { stringTable.id eq id }.single()[stringTable.city]))
assertEquals(updatedAddress, stringTable.selectAll().where { stringTable.id eq id }.single()[stringTable.address])
}
}
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
package org.jetbrains.exposed.sql.tests.shared.functions

import org.jetbrains.exposed.crypt.Algorithms
import org.jetbrains.exposed.crypt.Encryptor
import org.jetbrains.exposed.dao.id.IntIdTable
import org.jetbrains.exposed.sql.*
import org.jetbrains.exposed.sql.SqlExpressionBuilder.concat
import org.jetbrains.exposed.sql.SqlExpressionBuilder.eq
import org.jetbrains.exposed.sql.tests.DatabaseTestsBase
import org.jetbrains.exposed.sql.tests.TestDB
import org.jetbrains.exposed.sql.tests.currentDialectTest
Expand All @@ -15,7 +12,6 @@ import org.jetbrains.exposed.sql.tests.shared.dml.DMLTestsData
import org.jetbrains.exposed.sql.tests.shared.dml.withCitiesAndUsers
import org.jetbrains.exposed.sql.vendors.*
import org.junit.Test
import kotlin.test.assertEquals
import kotlin.test.assertNotNull
import kotlin.test.assertNull

Expand Down Expand Up @@ -614,28 +610,4 @@ class FunctionsTests : DatabaseTestsBase() {
assertEquals("Hi Andrey!", result3[concatField3])
}
}

private val encryptors = arrayOf(
"AES_256_PBE_GCM" to Algorithms.AES_256_PBE_GCM("passwd", "12345678"),
"AES_256_PBE_CBC" to Algorithms.AES_256_PBE_CBC("passwd", "12345678"),
"BLOW_FISH" to Algorithms.BLOW_FISH("sadsad"),
"TRIPLE_DES" to Algorithms.TRIPLE_DES("1".repeat(24))
)
private val testStrings = arrayOf("1", "2".repeat(10), "3".repeat(31), "4".repeat(1001), "5".repeat(5391))

@Test
fun `test output length of encryption`() {
fun testSize(algorithm: String, encryptor: Encryptor, str: String) =
assertEquals(
encryptor.maxColLength(str.toByteArray().size),
encryptor.encrypt(str).toByteArray().size,
"Failed to calculate length of $algorithm's output."
)

for ((algorithm, encryptor) in encryptors) {
for (testStr in testStrings) {
testSize(algorithm, encryptor, testStr)
}
}
}
}
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ sqlserver = "9.4.1.jre8"
springFramework = "6.1.4"
springBoot = "3.2.0"

spring-security-crypto = "5.8.8"
spring-security-crypto = "6.2.1"
joda-time = "2.12.7"
junit = "4.13.2"
kotlinx-datetime = "0.5.0"
Expand Down
Loading