fix: Tests testAdjustQueryHaving, testQueryAndHaving, and testQueryOrHaving resolve wrong eq function, and testGroupBy03 shows compiler warning
#2016
Conversation
There was a problem hiding this comment.
@joc-a Could you please confirm that this doesn't reintroduce any of the highlighted compiler warning issues detailed in PR #1961 and #1984 ? There are no tests for these warnings, just have to confirm with examples in the IDE and maybe running compileTestKotlin.
Especially since Count and Max return different types.
…eryOrHaving` resolve wrong `eq` function, and `testGroupBy03` shows compiler warning
The tests `testAdjustQueryHaving`, `testQueryAndHaving`, and `testQueryOrHaving` falsely resolve this `eq` function
infix fun <T : Comparable<T>, V : T?, E : EntityID<T>?> Expression<in V>.eq(
other: ExpressionWithColumnType<E>
): Op<Boolean> = other eq this
instead of this
infix fun <T, S1 : T?, S2 : T?> Expression<in S1>.eq(other: Expression<in S2>): Op<Boolean> = when (other as Expression<*>) {
is Op.NULL -> isNull()
else -> EqOp(this, other)
}
The same happens when using `neq`, `less`, `lessEq`, `greater`, and `greaterEq`, so those are fixed in this commit too.
Even when the correct function is resolved, a compiler warning still shows up because the compiler cannot infer the type of the argument when `Long` and `Int` are being compared. To remove the warning, the types are explicitly passed to the `eq` function like this `.eq<Number, Long, Int>`.
This was tested with Kotlin 2.0.0-Beta4.
joc-a
force-pushed
the
joc/fix-false-resolved-eq
branch
from
3f0deff
to
e18bf33
Compare
joc-a
changed the title
testAdjustQueryHaving, testQueryAndHaving, and testQueryOrHaving resolve wrong eq functiontestAdjustQueryHaving, testQueryAndHaving, and testQueryOrHaving resolve wrong eq function, and testGroupBy03 shows compiler warning
Confirmed by running |
The tests
testAdjustQueryHaving,testQueryAndHaving, andtestQueryOrHavingfalsely resolve thiseqfunctioninfix fun <T : Comparable, V : T?, E : EntityID?> Expression.eq(
other: ExpressionWithColumnType
): Op = other eq this
instead of this
infix fun <T, S1 : T?, S2 : T?> Expression.eq(other: Expression): Op = when (other as Expression<*>) {
is Op.NULL -> isNull()
else -> EqOp(this, other)
}
The same happens when using
neq,less,lessEq,greater, andgreaterEq, so those are fixed in this commit too.Even when the correct function is resolved, a compiler warning still shows up because the compiler cannot infer the type of the argument when
LongandIntare being compared. To remove the warning, the types are explicitly passed to theeqfunction like this.eq<Number, Long, Int>.This was tested with Kotlin 2.0.0-Beta4.