fix: EXPOSED-307 [SQLite] Delete ignore not supported and throws #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ax exception Attempting to use deleteIgnoreWhere() with SQLite throws a syntax exception because SQL is being generated even though MySQL and MariaDB are the only databases that support some variant of DELETE IGNORE. This adds a unit test for deleteIgnoreWhere() and ensures that it also fails early when used with SQLite.
e5l
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use
deleteIgnoreWhere()with SQLite results in:SQLiteDialect is currently setup to generate this SQL even though DELETE IGNORE is not supported:
DELETE IGNORE is only supported by MySQL and MariaDB and no test exists for it, so it's been added to the base delete tests.
SQLite now fails early, like all other DB, with
UnsupportedByDialectExceptionif ignore is set to true.