fix: EXPOSED-558 Entity cache for upsertReturning statements results in stale return values #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasharab
commented
Sep 22, 2024
| ItemDAO.wrapRow(it.single()) | ||
| } | ||
| assertEquals(1, result2.id.value) | ||
| assertEquals("B", result2.name) |
There was a problem hiding this comment.
Before my fix, this would fail.
rasharab
changed the title
rasharab
changed the title
We were noticing weird issues where DAOs returned using upsertReturning had stale values. We pinned it down to the EntityLifecycleInterceptor not correctly handling ReturningStatement upsertStatement cache evictions. The test I’ve added validates this and will fail without my changes.
rasharab
force-pushed
the
FixEntityCacheForReturningStatements
branch
from
f0b8f73
to
32214ac
Compare
bog-walk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
EntityLifecycleInterceptor.beforeExecution()now includes a branch to handle entity cache flushes forReturnStatement.mainStatement.Detailed description:
We were noticing weird issues where DAOs returned using upsertReturning had stale values.
We pinned it down to the EntityLifecycleInterceptor not correctly handling ReturningStatement upsertStatement cache evictions.
The test I’ve added validates this and will fail without my changes.
Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-558 ReturnStatements don't trigger entity cache flush before execution