Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Modify Oracle numeric data types #2268

Merged
merged 3 commits into from
Oct 10, 2024
Merged

chore!: Modify Oracle numeric data types #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c239753
chore!: Change Oracle and H2 Oracle ubyteType from NUMBER(4) to NUMBE…
joc-a Oct 2, 2024
769e240
chore!: Change Oracle and H2 Oracle ushortType from NUMBER(6) to NUMB…
joc-a Oct 2, 2024
0448217
chore!: Change Oracle and H2 Oracle uintegerType and uintegerAutoincT…
joc-a Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions documentation-website/Writerside/topics/Breaking-Changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
## 0.56.0
* If the `distinct` parameter of `groupConcat()` is set to `true`, when using Oracle or SQL Server, this will now fail early with an
`UnsupportedByDialectException`. Previously, the setting would be ignored and SQL function generation would not include a `DISTINCT` clause.
* In Oracle and H2 Oracle, the `ubyte()` column now maps to data type `NUMBER(3)` instead of `NUMBER(4)`.
* In Oracle and H2 Oracle, the `ushort()` column now maps to data type `NUMBER(5)` instead of `NUMBER(6)`.
* In Oracle and H2 Oracle, the `uinteger()` column now maps to data type `NUMBER(10)` instead of `NUMBER(13)`.

## 0.55.0
* The `DeleteStatement` property `table` is now deprecated in favor of `targetsSet`, which holds a `ColumnSet` that may be a `Table` or `Join`.
Expand Down
8 changes: 4 additions & 4 deletions exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/OracleDialect.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,17 @@ internal object OracleDataTypeProvider : DataTypeProvider() {
} else {
"NUMBER(3)"
}
override fun ubyteType(): String = "NUMBER(4)"
override fun ubyteType(): String = "NUMBER(3)"
override fun shortType(): String = if (currentDialect.h2Mode == H2Dialect.H2CompatibilityMode.Oracle) {
"SMALLINT"
} else {
"NUMBER(5)"
}
override fun ushortType(): String = "NUMBER(6)"
override fun ushortType(): String = "NUMBER(5)"
override fun integerType(): String = "NUMBER(12)"
override fun integerAutoincType(): String = "NUMBER(12)"
override fun uintegerType(): String = "NUMBER(13)"
override fun uintegerAutoincType(): String = "NUMBER(13)"
override fun uintegerType(): String = "NUMBER(10)"
override fun uintegerAutoincType(): String = "NUMBER(10)"
override fun longType(): String = "NUMBER(19)"
override fun longAutoincType(): String = "NUMBER(19)"
override fun ulongType(): String = "NUMBER(20)"
Expand Down
Loading