Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to MPS 2024.1.1 #1005

Merged
merged 18 commits into from
Nov 11, 2024
Merged

Conversation

alexanderpann
Copy link
Collaborator

@alexanderpann alexanderpann commented Nov 5, 2024

Nothing special changed. I only had issues with icon loading for plugin models that are nested in other models. Those models couldn't be opened in the logical view. The workaround seems to be to set Generate initializer config to true in the StandalonePluginDescriptor. The changes related to introducing the XML stubs are related to mbeddr. We need them available in MPS-Extensions since we depend in the batik stubs on then.

Note: We skipped MPS 2023.3 on purpose and decided to immediately go to MPS 2024.1.

Encountered known MPS issues:

Other non-migration-related issues:

@alexanderpann alexanderpann force-pushed the feature/migrate_to_2024_1 branch 7 times, most recently from ec26f23 to 7db41ab Compare November 7, 2024 11:31
Copy link
Collaborator

@sergej-koscejev sergej-koscejev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LineNumberComponent#install: the editor component disposed check should come even before trying to retrieve the project from the component.
  • MyConnectPreview, MyGraphComponent: getActionUpdateThread() is only the thread that actions will be updated on, they will still be executed in EDT. Since update is empty, it could be done on BGT because this is preferred.

Requesting changes because XML jars need to be dowloaded with Gradle, not checked into Git.

build.gradle Outdated Show resolved Hide resolved
code/xml/solutions/lib/resolver.jar Outdated Show resolved Hide resolved
@sergej-koscejev
Copy link
Collaborator

Please squash/fixup the commits that add and remove jars, so that we don't have the jars in Git history after merge.

@sergej-koscejev sergej-koscejev force-pushed the feature/migrate_to_2024_1 branch from d645792 to c05ada4 Compare November 8, 2024 18:38
@sergej-koscejev
Copy link
Collaborator

I fixed up the commits and force-pushed the branch.

@sergej-koscejev sergej-koscejev force-pushed the feature/migrate_to_2024_1 branch from c05ada4 to d72e3ff Compare November 8, 2024 19:59
@sergej-koscejev
Copy link
Collaborator

I am merging the MPS and JBR version update separately in #1010, so that we don't build a 9999.9 version from the 2024.1 branch.

@sergej-koscejev sergej-koscejev self-requested a review November 9, 2024 17:33
@sergej-koscejev sergej-koscejev dismissed their stale review November 10, 2024 10:01

Jar changes were implemented

@alexanderpann
Copy link
Collaborator Author

alexanderpann commented Nov 10, 2024

@sergej-koscejev Is there anything else that needs to be done, or can this PR be merged now?

@sergej-koscejev
Copy link
Collaborator

I want to understand why we need those resolver and serializer jars that come from this new Maven repository. Can we get rid of them?

@alexanderpann
Copy link
Collaborator Author

alexanderpann commented Nov 10, 2024

I guess you have to check the history in mbeddr why they were introduced: https://github.com/mbeddr/mbeddr.core/tree/master/code/languages/com.mbeddr.mpsutil/solutions/org.xml/lib
As mentioned privately before, the XML serializer is used by IETS3.

One use case at least is the batik language in mbeddr.core: https://github.com/mbeddr/mbeddr.core/tree/master/code/languages/com.mbeddr.mpsutil/solutions/org.apache.batik
I really would love to not touch those JARs anymore. If you remove the wrong one, the diagrams won't load. We had multiple classloading issues with this language in the past. The last time they broke was with the migration to 2023.2.

The new maven repo is really unfortunate but I couldn't find a better source.

@alexanderpann alexanderpann force-pushed the feature/migrate_to_2024_1 branch from d72e3ff to b54d7d6 Compare November 11, 2024 08:48
This stub was previously located in mbeddr

update the xml libraries and resolve them through maven
@sergej-koscejev sergej-koscejev force-pushed the feature/migrate_to_2024_1 branch from b54d7d6 to 0c4035c Compare November 11, 2024 09:15
@alexanderpann alexanderpann force-pushed the feature/migrate_to_2024_1 branch from d2130e7 to 52c618c Compare November 11, 2024 12:33
@alexanderpann alexanderpann merged commit 27bb8ec into maintenance/mps20241 Nov 11, 2024
1 check passed
@alexanderpann alexanderpann deleted the feature/migrate_to_2024_1 branch November 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants