-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to MPS 2024.1.1 #1005
Migrate to MPS 2024.1.1 #1005
Conversation
ec26f23
to
7db41ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LineNumberComponent#install
: the editor component disposed check should come even before trying to retrieve the project from the component.- MyConnectPreview, MyGraphComponent:
getActionUpdateThread()
is only the thread that actions will be updated on, they will still be executed in EDT. Since update is empty, it could be done on BGT because this is preferred.
Requesting changes because XML jars need to be dowloaded with Gradle, not checked into Git.
7fab1ae
to
d645792
Compare
Please squash/fixup the commits that add and remove jars, so that we don't have the jars in Git history after merge. |
d645792
to
c05ada4
Compare
I fixed up the commits and force-pushed the branch. |
c05ada4
to
d72e3ff
Compare
I am merging the MPS and JBR version update separately in #1010, so that we don't build a 9999.9 version from the 2024.1 branch. |
@sergej-koscejev Is there anything else that needs to be done, or can this PR be merged now? |
I want to understand why we need those resolver and serializer jars that come from this new Maven repository. Can we get rid of them? |
I guess you have to check the history in mbeddr why they were introduced: https://github.com/mbeddr/mbeddr.core/tree/master/code/languages/com.mbeddr.mpsutil/solutions/org.xml/lib One use case at least is the batik language in mbeddr.core: https://github.com/mbeddr/mbeddr.core/tree/master/code/languages/com.mbeddr.mpsutil/solutions/org.apache.batik The new maven repo is really unfortunate but I couldn't find a better source. |
d72e3ff
to
b54d7d6
Compare
This stub was previously located in mbeddr update the xml libraries and resolve them through maven
b54d7d6
to
0c4035c
Compare
d2130e7
to
52c618c
Compare
Nothing special changed. I only had issues with icon loading for plugin models that are nested in other models. Those models couldn't be opened in the logical view. The workaround seems to be to set
Generate initializer config
to true in theStandalonePluginDescriptor
. The changes related to introducing the XML stubs are related to mbeddr. We need them available in MPS-Extensions since we depend in the batik stubs on then.Note: We skipped MPS 2023.3 on purpose and decided to immediately go to MPS 2024.1.
Encountered known MPS issues:
Other non-migration-related issues: