[breaking] Enforce @NotNull annotations at runtime #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unnecessary dependency on IDEA and MPS build scripts other than `mps`. * Set Java compliance level to 11 in tests. * Add missing plugin to layout. * Mark a test solution as containing tests.
|
@slisson modelix/mpsbuild needs an option to generate javac2 tasks to remain consistent with the MPS-generated builds. |
sergej-koscejev
changed the title
sergej-koscejev
changed the title
sergej-koscejev
changed the base branch from
maintenance/mps20211
to
maintenance/mps20213
|
modelix/mpsbuild no longer used in the build so the comment about it doesn't apply |
alexanderpann
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the default compiler to IntelliJ (
<javac2>Ant task). Javac2 instruments code to ensure that@NotNullvariables are never null at run time.This is a breaking change because code that used to work before may start throwing exceptions now. However, it is likely that such code didn't work before anyway and it will now throw exceptions earlier in the call stack.